New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Vcs2d interactions updated #1091
Conversation
vtk_ui package included in install buttons now set state correctly on copy
Configurator intercepts click events on the canvas It then determines what DP template attribute was clicked on. It logs double clicks, and then will "activate" that member.
Removed old configurable code for template Changing tactics on how to approach configuration; moved configurable logic out of template, will move to attributes directly.
Can now detect clicks in arbitrary fillarea polygons
UI Widgets now render on their own renderer; not quite ironed out the issues with that technique yet, but the renderer is contained by the manager class, which is a singleton per render window. Also created the editors subpackage, which integrates vtk_ui elements directly with the things they that can configure, starting with the fillarea.
UI widgets will now show up on the top most layer, and will actually persist between canvas.update() calls. Woo!
Allows editing of color and fill style, though that appears to not work properly currently.
Extracted click/drag logic into mixin classes. Other editors will be able to use the exact same logic, woohoo. Interacting with a toolbar is still a bit fiddly, and there's tons of flashing; what's that all about?
Integrated into editors.fillarea and editors.line
Renders box on each tick of drag, decreased drag buffer zone
Fixes some whitespace issues that were left behind as well Conflicts: Packages/vcs/Lib/VTKPlots.py
…actions_updated Conflicts: Packages/DV3D/data/coastline/high/ne_10m_coastline.README.html Packages/DV3D/data/coastline/low/ne_110m_coastline.README.html Packages/DV3D/data/coastline/medium/ne_50m_coastline.README.html
@chaosphere2112 it seems that you may not have the developement hooks setup correctly? I fixed few things (whitespace, end of line, file size issues etc). Did you run SetupForDevelopement.sh script? |
@chaosphere2112 these are the tests failing: |
With my latest fix: only these now: |
With my latest fix, all of the tests are passing now. Merging it. |
@aashish24 I do on my work computer, but not my personal, I'd wager. Thanks for merging! |
No description provided.